Re: [Qemu-devel] [PATCH] e1000: Do reset when E1000_CTRL_RST bit is set.

[Richard Henderson]

On 08/05/2011 09:53 AM, Anthony Liguori wrote:
>> +    if (val&  E1000_CTRL_RST) {
> 
> You'll break some GCCs with -Wall -Werror with this.  Please do:
> 
> if ((val & E1000_CTRL_RST)) {

Err, really?  What versions?

I don't recall that ever being true.


r~