On 9 August 2011 15:10, Anthony PERARD <anthony.per...@citrix.com> wrote: > On Fri, Aug 5, 2011 at 17:53, Anthony Liguori <anth...@codemonkey.ws> wrote: >> >> You'll break some GCCs with -Wall -Werror with this. Please do: >> >> if ((val & E1000_CTRL_RST)) { > > :(, I never heard of this. But OK, I will do that.
Please don't unless Anthony L can actually demonstrate a compiler which has this property and doesn't already complain about all the existing equivalent code in qemu... -- PMM