On 5 August 2011 17:53, Anthony Liguori <anth...@codemonkey.ws> wrote: > You'll break some GCCs with -Wall -Werror with this. Please do: > > if ((val & E1000_CTRL_RST)) {
Hmm? There's lots of examples of that in the codebase: $ git grep 'if ([a-zA-Z]* & ' | wc -l 1558 '=' (assignment) needs those extra braces, but logical ops don't AFAIK. -- PMM