On Wed, 9 Jun 2021 at 22:16, Richard Henderson <richard.hender...@linaro.org> wrote: > > On 6/7/21 9:58 AM, Peter Maydell wrote: > > +/* > > + * VCADD Qd == Qm at size MO_32 is UNPREDICTABLE; we choose not to diagnose > > + * so we can reuse the DO_2OP macro. (Our implementation calculates the > > + * "expected" results in this case.) > > + */ > You've done this elsewhere, though.
Yeah, because in those cases the op had to have its own hand-written trans_ function for other reasons so the check was easy to add. Hence the comment about why this particular case doesn't do that. > Either way, > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> thanks -- PMM