Hi, On 12/30/21 15:30, liweiwei wrote: > - share it between target/arm and target/riscv
"Share sm4_sbox between ARM and RISCV targets."? > > Signed-off-by: liweiwei <liwei...@iscas.ac.cn> > Signed-off-by: wangjunqiang <wangjunqi...@iscas.ac.cn> > --- > crypto/meson.build | 1 + > crypto/sm4.c | 48 ++++++++++++++++++++++++++++++++++++++ > include/crypto/sm4.h | 6 +++++ > meson | 2 +- > target/arm/crypto_helper.c | 36 +--------------------------- > 5 files changed, 57 insertions(+), 36 deletions(-) > diff --git a/crypto/sm4.c b/crypto/sm4.c > new file mode 100644 > index 0000000000..1cdcb8a620 > --- /dev/null > +++ b/crypto/sm4.c > +uint8_t const sm4_sbox[] = { Please explicit the [256] array size. > diff --git a/meson b/meson > index 12f9f04ba0..b25d94e7c7 160000 > --- a/meson > +++ b/meson > @@ -1 +1 @@ > -Subproject commit 12f9f04ba0decfda425dbbf9a501084c153a2d18 > +Subproject commit b25d94e7c77fda05a7fdfe8afe562cf9760d69da Unrelated change... Otherwise (without the submodule change): Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> Thanks, Phil.