On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen <chen.zh...@intel.com> wrote: > > If the checkpoint occurs when the guest finishes restarting > but has not started running, the runstate_set() may reject > the transition from COLO to PRELAUNCH with the crash log: > > {"timestamp": {"seconds": 1593484591, "microseconds": 26605},\ > "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}} > qemu-system-x86_64: invalid runstate transition: 'colo' -> 'prelaunch' > > Long-term testing says that it's pretty safe. > > Signed-off-by: Like Xu <like...@linux.intel.com> > Signed-off-by: Zhang Chen <chen.zh...@intel.com>
I'd expect this to get ack from the relevant maintainers. Thanks > --- > softmmu/runstate.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/softmmu/runstate.c b/softmmu/runstate.c > index e0d869b21a..c021c56338 100644 > --- a/softmmu/runstate.c > +++ b/softmmu/runstate.c > @@ -127,6 +127,7 @@ static const RunStateTransition > runstate_transitions_def[] = { > { RUN_STATE_RESTORE_VM, RUN_STATE_PRELAUNCH }, > > { RUN_STATE_COLO, RUN_STATE_RUNNING }, > + { RUN_STATE_COLO, RUN_STATE_PRELAUNCH }, > { RUN_STATE_COLO, RUN_STATE_SHUTDOWN}, > > { RUN_STATE_RUNNING, RUN_STATE_DEBUG }, > -- > 2.25.1 >