On Sun, 22 Jan 2023 18:07:17 +0100
Bernhard Beschow <shen...@gmail.com> wrote:
> This series brings the PIIX4 PM device closer to reality and resolves some
> redundant code along the way.
I'm done with this series review
>
> Testing done:
> - `make check`
> - Starting a live CD under pc and q35 machines and check that the GPE accesses
> are traced
>
> Bernhard Beschow (7):
> hw/acpi/{ich9,piix4}: Reuse existing attributes for QOM properties
> hw/acpi/ich9: Remove unneeded assignments
> hw/acpi/{ich9,piix4}: Resolve redundant io_base address attributes
> hw/acpi/ich9: Use ICH9_PMIO_GPE0_STS just once
> hw/acpi/piix4: Fix offset of GPE0 registers
> hw/acpi: Trace GPE access in all device models, not just PIIX4
> hw/acpi/core: Trace enable and status registers of GPE separately
>
> include/hw/acpi/ich9.h | 1 -
> include/hw/acpi/piix4.h | 3 +--
> hw/acpi/core.c | 9 +++++++++
> hw/acpi/ich9.c | 26 ++++++++++++--------------
> hw/acpi/piix4.c | 31 ++++++++++++++++---------------
> hw/acpi/trace-events | 10 ++++++----
> 6 files changed, 44 insertions(+), 36 deletions(-)
>
