Tejus GK <tejus...@nutanix.com> wrote: > There are places outside of migration.c which eventually leads to a > migration failure, but the failure reason is never updated. Hence > libvirt doesn't know why the migration failed when it queries for it. > > Signed-off-by: Tejus GK <tejus...@nutanix.com>
Reviewed-by: Juan Quintela <quint...@redhat.com> If you have to respin: > @@ -1456,6 +1460,7 @@ int > qemu_savevm_state_complete_precopy_non_iterable(QEMUFile *f, > int vmdesc_len; > SaveStateEntry *se; > int ret; > + Error *local_err = NULL; You can declare this: > QTAILQ_FOREACH(se, &savevm_state.handlers, entry) { > if (se->vmsd && se->vmsd->early_setup) { > @@ -1475,8 +1480,10 @@ int > qemu_savevm_state_complete_precopy_non_iterable(QEMUFile *f, > * bdrv_activate_all() on the other end won't fail. */ > ret = bdrv_inactivate_all(); > if (ret) { here > - error_report("%s: bdrv_inactivate_all() failed (%d)", > - __func__, ret);