On Thursday 26 January 2006 13:22, Gary V. Vaughan wrote: > Andreas Gruenbacher wrote: > > I have removed our reliance on ftw and implemented directory walking in > > lib/backup-files.c itself based on Gary's proposal, > > <http://lists.gnu.org/archive/html/quilt-dev/2005-09/msg00133.html>. > > Gary, it took a while, but eventually you've won -- thank you ;) > > Cool. Thanks :-D > > > Could you guys please review the changes, and check if backup-files now > > builds on the platforms we are targeting? > > Works for me on darwin, although there are new test failures... > > The Mac OSX version of find (a BSD derivative) doesn't understand -printf, > but the test in configure.ac only tests for a find that understands -path > (which this one does). > > Patch to revert that change to avoid forcing Mac users to build and install > GNU findutils is attached.
That's bad. I'd prefer the attached version; it doesn't need the loop. > Also, I note that my patch 11 is still pending, and required on any machine > where the first cp, diff, awk etc. on the caller's PATH are not the > versions checked for and found by configure. > > http://lists.gnu.org/archive/html/quilt-dev/2005-09/msg00289.html Checked in, thanks. Andreas
Index: quilt/scripts/patchfns.in =================================================================== RCS file: /sources/quilt/quilt/quilt/scripts/patchfns.in,v retrieving revision 1.10 diff -u -r1.10 patchfns.in --- quilt/scripts/patchfns.in 24 Jan 2006 02:32:31 -0000 1.10 +++ quilt/scripts/patchfns.in 26 Jan 2006 12:35:37 -0000 @@ -594,9 +594,11 @@ if [ -d "$path" ] then - find "$path" -type f \ - -a ! -path "$path/.timestamp" \ - -printf "%P\n" + local files + files=( $(find "$path" -type f \ + -a ! -path "$path/.timestamp") ) \ + || return 1 + printf "%s\n" "[EMAIL PROTECTED]/}" fi }
_______________________________________________ Quilt-dev mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/quilt-dev
