On 2011-11-19, Gavin McDonald wrote: > All I did here was add a space for alignment, I'm not seeing how that > could make the reportTest fail:
The test compares the generated report with an expected layout. The space you've added adds a two space characters into the report. The section that lists the first lines of the file without license now has an extra space in front of the very first line of the file. It seems to me as if RAT-3 has been re-intorduced by the change rather than fixed and the test was broken because it asserted RAT-3 was fixed (as a side effect it not really is a unit test or even specific for this issue). Sebb's comment on RAT-3 really is different from the original issue. The original issue is about the snippet being different from the actual content of the file and I agree it shouldn't be. I.e. I wouldn't want to indent the original file content at all. Sebb's comment is about the header above the file content being indented while file content is not. Not sure what t make out of it. Whether an indented header is good or bad really is a matter of taste to me. Stefan
