> -----Original Message----- > From: sebb [mailto:seb...@gmail.com] > Sent: Monday, 21 November 2011 8:17 AM > To: rat-dev@incubator.apache.org; ga...@16degrees.com.au > Subject: Re: buildbot failure in ASF Buildbot on rat_trunk > > On 20 November 2011 08:30, Gavin McDonald <ga...@16degrees.com.au> > wrote: > > > > > >> -----Original Message----- > >> From: Stefan Bodewig [mailto:bode...@apache.org] > >> Sent: Sunday, 20 November 2011 4:16 PM > >> To: rat-dev@incubator.apache.org > >> Cc: ga...@16degrees.com.au > >> Subject: Re: buildbot failure in ASF Buildbot on rat_trunk > >> > >> On 2011-11-19, Gavin McDonald wrote: > >> > >> > All I did here was add a space for alignment, I'm not seeing how > >> > that could make the reportTest fail: > >> > >> The test compares the generated report with an expected layout. The > >> space you've added adds a two space characters into the report. > >> > >> The section that lists the first lines of the file without license > >> now has > > an > >> extra space in front of the very first line of the file. > >> > >> It seems to me as if RAT-3 has been re-intorduced by the change > >> rather > > than > >> fixed and the test was broken because it asserted RAT-3 was fixed (as > >> a > > side > >> effect it not really is a unit test or even specific for this issue). > >> > >> Sebb's comment on RAT-3 really is different from the original issue. > > > > > > True > > > >> > >> The original issue is about the snippet being different from the > >> actual > > content > >> of the file and I agree it shouldn't be. I.e. I wouldn't want to > >> indent > > the > >> original file content at all. > >> > >> Sebb's comment is about the header above the file content being > >> indented while file content is not. Not sure what t make out of it. > >> Whether an indented header is good or bad really is a matter of taste to > me. > > > > I thought my change made the content indented, which is exactly what > > he asked for. > > Not quite. > > The original problem was that the header and first line were indented.
Correct, I spotted that. > > The original fix removed the extra first line indent. Yep, spotted that too. > > It just seems odd to indent the header when the file contents is not > indented. ack, agree with that and spotted that was your point. > > I would expect either both to be indented 1 space, or neither. exactly, is that not precisely what my commit did ????? Gav... > > > If you disagree then by all means revert and close the issue, > > otherwise I'll look to make the test case match. > > > > Gav.. > > > >> > >> Stefan > > > >
