Hi,
On Thu, 2008-12-04 at 10:56 +0100, Ille wrote:
> > > I'm still trying to improve the foveon/x3f support in rawstudio.
> > > I can now reload the x3f, giving the user the ability to
> > > change on the fly the in-camera white balance set when shooting
> > > (Sunlight, Shade, Overcast, Incandescent, Fluorescent, Flash, Auto
> > > or Custom). But as stated, it needs a full reload of the file, so I
> > > can't have different camera WB settings for each snapshot.
> > >
> > > I would like to access the rs->toolbox widget from within
> > > x3f-meta.c to be able to add a notebook page when loading a x3f
> > > file. Is there a way to do it using photo->parent, which is a
> > > GObject?
> > All functions in meta-loaders must be self-contained, or at least not
> > require anything from the GUI.
> OK, but then maybe I can add a popup window?
Not to the metadata reader at least. Metadata reading is done when the
directory is opened - one thread per cpu core - it can load hundreds of
images in a few seconds, you don't really want to see all those
popups ;)
> > As of now there really isn't any easy way to do what you're proposing
> > in Rawstudio - I have an idea thou:
> >
> > Abstract the white balance somewhat away from RSMetadata, and let the
> > metaloaders export a list of possible white balances the
> > toolbox/toolchain can select from at a later stage.
> >
> > Maybe it can even be simpler, add a simple struct:
> >
> > typedef struct _RSWhiteBalance {
> > const gchar *title; /* FIXME: Should this be translated? */
> > gfloat *multipliers[4]; /* Multipliers for R, G, B and G2 */
> > gfloat temperature; /* Unused by now, prepare for the future */
> > } RSWhiteBalance;
> >
> > In RSMetadata, the following fields could replace cam_mul:
> > GSList wb; /* A list of white balances to choose from */
> > gint current_wb; /* An index to use with g_slist_nth_data() */
> >
> > It's a somewhat big change thou...
>
> Well, x3f files store all in-camera White Balance settings as 3x3
> matrix. But the white balance correction is applied by dcraw at the
> very first beginning of foveon_interpolate. My purpose was to override
> the white balance setting which was set when shooting. For this I
> modified dcraw_api.cc
Oh. It does "something" more than just plain white balance. We really
have nothing even resembling code to support this.
My best guess is to look at adobe_coeff_set(), that applies 3x3 matrices
to images (based on matrices borrowed from Adobe's DNG converter). This
might give some clues to how this could be handled.
> I didn't want to make so big changes to rawstudio, because foveon based
> camera are quiet rare compared to other brands.
Well. We should handle them correct regardless of popularity.
> Maybe it could be possible to add a page in the notebook which already
> contains the toolbox, batchbox and dir_selector, and keep this page for
> meta-loaders usage? Or add a #define X3F_SPECIFIC so that users can
> choose at compile-time if they want some extra features for X3F?
By principle we don't want any compile time options for Rawstudio.
> By the way, I think there is a bug when opening x3f files which do NOT
> need demosaic. Those are actually opened at double size, causing the
> preview to be a little bit blurry... I join a patch to correct this
> behaviour. The patch also take care of the auto-rotation of the x3f
> thumbnail and image.
Oh that was a nasty bug! Are you sure that filters and fourColorFilters
are valid with this fix?
Regarding rotation in X3F-images, are you sure the rotation works as
expected? Will the loaded image (and not just the thumbnail) be rotated
as expected?
Could you upload a couple of x3f shots with different orientation to
ftp://rawstudio.org/incoming-raws/ ?
/abrander
_______________________________________________
Rawstudio-dev mailing list
[email protected]
http://rawstudio.org/cgi-bin/mailman/listinfo/rawstudio-dev
