On Thu, 12 Dec 2019 02:35:34 +0000
dllud <dl...@riseup.net> wrote:

> Sorry, my bad, as Joonas correctly reviewed, the last patch shouldn't
> be merged.
> Instead, "ro.libagl=0" should be set in
> vendor/replicant/config/common.mk in order to have llvmpipe as
> default. 
Thanks. During testing, I was wondering why it wasn't set, now I
get it.

> Along with that we need the two commits from adjtm that I
> mentioned previously, otherwise the system will be too slow.
I've prepared a patch with that but while it may look good it's nowhere
ready:
- I need the permission to add signed-off-by from Andrés Domínguez
- The commit message reflects what it's supposed to do but I've no idea
  how it's supposed to work. All I see is that it copies some empty
  files in some specific locations.
- As I don't understand how it works, I don't understand either how to
  test it.

As I've added the llvmpipe.sh and androidsw.sh scripts to the image, I
just had to run llvmpipe.sh to enable llvmpipe. Once that was done, I
found the "desktop/launcher" way slower than with ro.libagl=1.

Beside that I'm not sure how fast it's supposed to be.

Denis.
From 89f79f3677250acfb0bcd1fe5245265fbbe438ea Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9s=20Dom=C3=ADnguez?= <andres...@gmail.com>
Date: Tue, 9 Apr 2019 15:39:56 +0000
Subject: [PATCH] [WIP] Add configuration files for default libGLES overlays

Libagl was previously used for all applications. That
prevented to use applications like IceCatMobile, which were
crashing because libagl OpenGL implementation was
incomplete.

To fix that, LLVMpipe is now used by default, however this
creates some huge performance issues for the following
system components:
- bootanimation
- SurfaceFlinger
- system_server

As theses system components are known to work well with
libagl, and that having different OpenGL implementations
doesn't seem to create any issue, it's safe to switch them
back to libagl.

gnu...@cyberdimension.org: squashed commits, commit message: added background
Signed-off-by: Denis 'GNUtoo' Carikli <gnu...@cyberdimension.org>
---
 config/common.mk                                              | 4 ++++
 prebuilt/common/etc/libGLES_android/system/bin/bootanimation  | 0
 prebuilt/common/etc/libGLES_android/system/bin/surfaceflinger | 0
 prebuilt/common/etc/libGLES_android/system_server             | 0
 4 files changed, 4 insertions(+)
 create mode 100644 prebuilt/common/etc/libGLES_android/system/bin/bootanimation
 create mode 100644 prebuilt/common/etc/libGLES_android/system/bin/surfaceflinger
 create mode 100644 prebuilt/common/etc/libGLES_android/system_server

diff --git a/config/common.mk b/config/common.mk
index a79025f6..8d7d841d 100644
--- a/config/common.mk
+++ b/config/common.mk
@@ -90,6 +90,10 @@ PRODUCT_COPY_FILES += \
 PRODUCT_COPY_FILES += \
     vendor/replicant/prebuilt/common/etc/firmware/htc_9271.fw:system/etc/firmware/htc_9271.fw
 
+# Copy default EGL overrides
+PRODUCT_COPY_FILES += \
+    $(call find-copy-subdir-files,*,vendor/replicant/prebuilt/common/etc/libGLES_android,system/etc/libGLES_android)
+
 # Include CM audio files
 include vendor/replicant/config/cm_audio.mk
 
diff --git a/prebuilt/common/etc/libGLES_android/system/bin/bootanimation b/prebuilt/common/etc/libGLES_android/system/bin/bootanimation
new file mode 100644
index 00000000..e69de29b
diff --git a/prebuilt/common/etc/libGLES_android/system/bin/surfaceflinger b/prebuilt/common/etc/libGLES_android/system/bin/surfaceflinger
new file mode 100644
index 00000000..e69de29b
diff --git a/prebuilt/common/etc/libGLES_android/system_server b/prebuilt/common/etc/libGLES_android/system_server
new file mode 100644
index 00000000..e69de29b
-- 
2.24.0

Attachment: pgpmUJ3f80m8J.pgp
Description: OpenPGP digital signature

_______________________________________________
Replicant mailing list
Replicant@osuosl.org
https://lists.osuosl.org/mailman/listinfo/replicant

Reply via email to