Hi John, Easiest way, if it works for you, might be to just fetch the uploaded diff and compare. If you look at the URL for Download Diff on a review request, you'll see the kind of URL you'd need to compose. Generate a diff locally and compare that to the diff going in.
Alternatively, you can compare the SHAs of the files. To do this, you need to loop over all files in the diff on the review request using the API. You can see this resource for info: https://www.reviewboard.org/docs/manual/2.5/webapi/2.0/resources/file-diff-list/ Note in the example payloads the "extra_data.patched_sha1" key. This is the SHA1 of the patched file, the one going into the commit. If you want to compare file contents and not the diff, you can get all these for the latest diff revision on the review request, and compare those. Something to note is that the file contents may be altered at some point in ways that would affect the checksum (newlines normalized, file encodings being applied on our end or the repository end to get contents to match up). So depending on your setup, that may come into play. Hope that helps! Christian -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> On Wed, Jul 6, 2016 at 9:44 AM, john levin <smart.le...@gmail.com> wrote: > Hi Chris, > > Thanks for your reply ! > > We are validating the list of files in a review id and the files trying to > commit in SVN (using precommit hook). But it is not a proper way.problem > here is People can use the same review id and can make changes and commit > to svn without updating the review. So we are trying to validate with diff > or (some sort of CRC for that particular review id). > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
