> On March 27, 2017, 11:49 a.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
> > Lines 97 (patched)
> > <https://reviews.apache.org/r/57959/diff/1/?file=1676915#file1676915line97>
> >
> >     The `master_kdc` value can be a comma-delimited list, so this list will 
> > need to be split else you might wind up with 
> >     
> >     ```
> >     kdc_host = host1.example.com, host2.example.com,host3.example.com
> >     ```

I think this is incorrect and there may only be a single master KDC allowed.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/#review170186
-----------------------------------------------------------


On March 27, 2017, 10:54 a.m., Balázs Bence Sári wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57959/
> -----------------------------------------------------------
> 
> (Updated March 27, 2017, 10:54 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20586
>     https://issues.apache.org/jira/browse/AMBARI-20586
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added master_kdc to kerberos env and the krb5 config template.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  25f2001 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  965ee13 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  57f062a 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
>  7016437 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  fa2082b 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
> 6727b2f 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 
> 
> 
> Diff: https://reviews.apache.org/r/57959/diff/2/
> 
> 
> Testing
> -------
> 
> - Tested manually
> - Updated Java unit tests
> - All ambari-server unit tests pass.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Reply via email to