-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/
-----------------------------------------------------------

(Updated March 30, 2017, 7:04 p.m.)


Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor 
Magyari, and Sebastian Toader.


Changes
-------

Review comments.


Bugs: AMBARI-20586
    https://issues.apache.org/jira/browse/AMBARI-20586


Repository: ambari


Description
-------

Added master_kdc to kerberos env and the krb5 config template.


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 25f2001 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
 965ee13 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
 c692b92 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
 8cb1f0c 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
 57f062a 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
 0191953 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
 7016437 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
 c692b92 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_common.py
 70c81e7 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/params.py
 3533b35 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
 0191953 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 fa2082b 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
6727b2f 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 


Diff: https://reviews.apache.org/r/57959/diff/4/

Changes: https://reviews.apache.org/r/57959/diff/3-4/


Testing
-------

- Tested manually
- Updated Java unit tests
- All ambari-server unit tests pass.


Thanks,

Balázs Bence Sári

Reply via email to