> On March 27, 2017, 3:18 p.m., Sebastian Toader wrote: > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml > > Line 91 (original), 94 (patched) > > <https://reviews.apache.org/r/57959/diff/1/?file=1676915#file1676915line94> > > > > I'm not familiar with master - slave KDC setup but if I understand > > correctly > > ```https://web.mit.edu/kerberos/krb5-1.13/doc/admin/install_kdc.html#start-kdc-daemons``` > > than the admin server has to be collocated (or not?) with master KDC > > server. > > > > Can you perform a test scenario to verify this?
Collocation depends on how the KDC database is stored: "kadmind starts the Kerberos administration server. kadmind typically runs on the master Kerberos server, which stores the KDC database. If the KDC database uses the LDAP module, the administration server and the KDC server need not run on the same machine." https://web.mit.edu/kerberos/krb5-1.13/doc/admin/admin_commands/kadmind.html#kadmind-8 > On March 27, 2017, 3:18 p.m., Sebastian Toader wrote: > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml > > Lines 93-95 (original), 96-101 (patched) > > <https://reviews.apache.org/r/57959/diff/1/?file=1676915#file1676915line96> > > > > shouldn't this be an "else if" > > Robert Levas wrote: > I don't think so. This looks correct to me. It appears that the code > is adding an additional kdc_host for the master_kdc if it was not manually > added to the kdc_hosts list. Yes, this was the intention - Balázs Bence ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57959/#review170180 ----------------------------------------------------------- On March 27, 2017, 2:54 p.m., Balázs Bence Sári wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57959/ > ----------------------------------------------------------- > > (Updated March 27, 2017, 2:54 p.m.) > > > Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor > Magyari, and Sebastian Toader. > > > Bugs: AMBARI-20586 > https://issues.apache.org/jira/browse/AMBARI-20586 > > > Repository: ambari > > > Description > ------- > > Added master_kdc to kerberos env and the krb5 config template. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 25f2001 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml > 965ee13 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml > c692b92 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py > 57f062a > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2 > 0191953 > > ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml > 7016437 > > ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml > c692b92 > > ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2 > 0191953 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > fa2082b > ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py > 6727b2f > ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 > > > Diff: https://reviews.apache.org/r/57959/diff/2/ > > > Testing > ------- > > - Tested manually > - Updated Java unit tests > - All ambari-server unit tests pass. > > > Thanks, > > Balázs Bence Sári > >
