> On Dec. 21, 2016, 4:33 p.m., Aurora ReviewBot wrote: > > Master (38b9311) is red with this patch. > > ./build-support/jenkins/build.sh > > > > at > > org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120) > > at > > org.gradle.launcher.daemon.server.exec.RequestStopIfSingleUsedDaemon.execute(RequestStopIfSingleUsedDaemon.java:34) > > at > > org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120) > > at > > org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:74) > > at > > org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:72) > > at org.gradle.util.Swapper.swap(Swapper.java:38) > > at > > org.gradle.launcher.daemon.server.exec.ForwardClientInput.execute(ForwardClientInput.java:72) > > at > > org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120) > > at > > org.gradle.launcher.daemon.server.exec.LogAndCheckHealth.execute(LogAndCheckHealth.java:55) > > at > > org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120) > > at > > org.gradle.launcher.daemon.server.exec.LogToClient.doBuild(LogToClient.java:60) > > at > > org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36) > > at > > org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120) > > at > > org.gradle.launcher.daemon.server.exec.EstablishBuildEnvironment.doBuild(EstablishBuildEnvironment.java:72) > > at > > org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36) > > at > > org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120) > > at > > org.gradle.launcher.daemon.server.exec.HintGCAfterBuild.execute(HintGCAfterBuild.java:44) > > at > > org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120) > > at > > org.gradle.launcher.daemon.server.exec.StartBuildOrRespondWithBusy$1.run(StartBuildOrRespondWithBusy.java:50) > > at > > org.gradle.launcher.daemon.server.DaemonStateCoordinator$1.run(DaemonStateCoordinator.java:293) > > at > > org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54) > > at > > org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40) > > at > > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > > at > > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > > at java.lang.Thread.run(Thread.java:745) > > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java:95: > > Missing arguments, expected 1 argument but have 0 > > :pmdMain FAILED > > > > FAILURE: Build failed with an exception. > > > > * What went wrong: > > Execution failed for task ':pmdMain'. > > > 1 PMD rule violations were found. See the report at: > > > file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/pmd/main.html > > > > * Try: > > Run with --stacktrace option to get the stack trace. Run with --info or > > --debug option to get more log output. > > > > BUILD FAILED > > > > Total time: 2 mins 27.377 secs > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry"
This seems to be PMD bug in the rule https://pmd.github.io/pmd-5.5.2/pmd-java/xref/net/sourceforge/pmd/lang/java/rule/logging/InvalidSlf4jMessageFormatRule.html. Replacing the expression with a variable reference made it go away. - Mehrdad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/#review159894 ----------------------------------------------------------- On Dec. 21, 2016, 4:30 p.m., Mehrdad Nurolahzade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54959/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2016, 4:30 p.m.) > > > Review request for Aurora, Joshua Cohen and Stephan Erb. > > > Bugs: AURORA-1842 > https://issues.apache.org/jira/browse/AURORA-1842 > > > Repository: aurora > > > Description > ------- > > AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java > 8cd7bfe18716e38da79df9c869a69bccfe1afe1b > > Diff: https://reviews.apache.org/r/54959/diff/ > > > Testing > ------- > > ``` > curl 192.168.33.7:8081/vars | grep row_garbage_collector > % Total % Received % Xferd Average Speed Time Time Time > Current > Dload Upload Total Spent Left Speed > 100 41761 0 41761 0 0 6407k 0 --:--:-- --:--:-- --:--:-- 6797k > row_garbage_collector_deleted 0 > row_garbage_collector_run_events 1 > row_garbage_collector_run_events_per_sec 0.0 > row_garbage_collector_run_nanos_per_event 0.0 > row_garbage_collector_run_nanos_total 127851591 > row_garbage_collector_run_nanos_total_per_sec 0.0 > ``` > > > Thanks, > > Mehrdad Nurolahzade > >
