> On Dec. 21, 2016, 6:26 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java, > > lines 97-98 > > <https://reviews.apache.org/r/54959/diff/2/?file=1590828#file1590828line97> > > > > Inline?
This was originally inline but threw PMD off somehow, refactoring to a variable fixed it (see my comment above on ReviewBot error message). I just noticed that wrapping the expression in a `Long` also makes PMD happy. - Mehrdad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/#review159914 ----------------------------------------------------------- On Dec. 21, 2016, 10:49 p.m., Mehrdad Nurolahzade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54959/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2016, 10:49 p.m.) > > > Review request for Aurora, Joshua Cohen and Stephan Erb. > > > Bugs: AURORA-1842 > https://issues.apache.org/jira/browse/AURORA-1842 > > > Repository: aurora > > > Description > ------- > > AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java > 8cd7bfe18716e38da79df9c869a69bccfe1afe1b > > Diff: https://reviews.apache.org/r/54959/diff/ > > > Testing > ------- > > ``` > curl 192.168.33.7:8081/vars | grep row_garbage_collector > % Total % Received % Xferd Average Speed Time Time Time > Current > Dload Upload Total Spent Left Speed > 100 41761 0 41761 0 0 6407k 0 --:--:-- --:--:-- --:--:-- 6797k > row_garbage_collector_deleted 0 > row_garbage_collector_run_events 1 > row_garbage_collector_run_events_per_sec 0.0 > row_garbage_collector_run_nanos_per_event 0.0 > row_garbage_collector_run_nanos_total 127851591 > row_garbage_collector_run_nanos_total_per_sec 0.0 > ``` > > > Thanks, > > Mehrdad Nurolahzade > >
