----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/#review159914 -----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java (line 67) <https://reviews.apache.org/r/54959/#comment230969> requireNonNull is just used to give an early and clear signal of where a null object was passed when it shouldn't be. If you're calling a method on the object in the constructor like this, it's redundant. src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java (lines 97 - 98) <https://reviews.apache.org/r/54959/#comment230970> Inline? - David McLaughlin On Dec. 22, 2016, 1:11 a.m., Mehrdad Nurolahzade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54959/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2016, 1:11 a.m.) > > > Review request for Aurora, Joshua Cohen and Stephan Erb. > > > Bugs: AURORA-1842 > https://issues.apache.org/jira/browse/AURORA-1842 > > > Repository: aurora > > > Description > ------- > > AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java > 8cd7bfe18716e38da79df9c869a69bccfe1afe1b > > Diff: https://reviews.apache.org/r/54959/diff/ > > > Testing > ------- > > ``` > curl 192.168.33.7:8081/vars | grep row_garbage_collector > % Total % Received % Xferd Average Speed Time Time Time > Current > Dload Upload Total Spent Left Speed > 100 41761 0 41761 0 0 6407k 0 --:--:-- --:--:-- --:--:-- 6797k > row_garbage_collector_deleted 0 > row_garbage_collector_run_events 1 > row_garbage_collector_run_events_per_sec 0.0 > row_garbage_collector_run_nanos_per_event 0.0 > row_garbage_collector_run_nanos_total 127851591 > row_garbage_collector_run_nanos_total_per_sec 0.0 > ``` > > > Thanks, > > Mehrdad Nurolahzade > >