-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62692/#review187857
-----------------------------------------------------------



Looks good to me in general.

We'll need to update the docs as well. Please:

* Add a section to the RELEASE-NOTES to indicate that scheduler environments 
are now configurable on the scheduler side
* Update the docs. In particular 
https://github.com/apache/aurora/blob/master/docs/features/multitenancy.md#job-namespaces
 and 
https://github.com/apache/aurora/blob/master/docs/reference/configuration.md#job-objects
 should be updated that these are just the defaults but could be changed by an 
operator

Thanks!


src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
Lines 70 (patched)
<https://reviews.apache.org/r/62692/#comment264891>

    IIRC, the OR operator has the lowest precedence. This would imply we'd need 
to change this regex to `^(prod|devel|test|staging\d*)$`



src/main/python/apache/aurora/client/config.py
Lines 58-73 (original)
<https://reviews.apache.org/r/62692/#comment264892>

    I am ok with this, but I am calling this out so that everyone is aware: 
    
    With this change a new client will be able to create arbitrary environments 
on old scheduler instances.


- Stephan Erb


On Oct. 12, 2017, 8:20 p.m., Mauricio Garavaglia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62692/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2017, 8:20 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Moves the job environment validation to the scheduler, which can be enabled 
> with the scheduler require_predefined_environments flag. This allows to have 
> a consistent behavior when using the CLI and the API. In order to preserve 
> backward compatibility, the validation is kept in the CLI and for the API it 
> needs to be manually enabled in the scheduler.
> 
> 
> Diffs
> -----
> 
>   docs/reference/scheduler-configuration.md 
> 4e3f90713c307e3b9e9f84c29343af7f014f0165 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 081dff2bda626f01ba222628b8d7d8afebbb0004 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 186fa1b3a4780c0536fb486d50a33133258110cd 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  754fde0fdc976b673d78ae15d8ccd8c85b792373 
>   src/main/python/apache/aurora/client/config.py 
> 70c2c980309e18de576b251087cdfea00ac06b75 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  50d7499f4332a3feb0e2301cb707f2cea6bb2e98 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 
> 8556253fc11f6027316871eb9dc66d8627a77fe6 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java 
> 3c5ecd698557cafdf8eeacdc472589a379018896 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  9c446682750706aecdc67062ae82f2a76ab38043 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> 6b4b17f8dafd5c2d751dcda3080b476335f8aec0 
> 
> 
> Diff: https://reviews.apache.org/r/62692/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mauricio Garavaglia
> 
>

Reply via email to