----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review188068 -----------------------------------------------------------
Master (2aee90d) is red with this patch. ./build-support/jenkins/build.sh src/test/python/apache/thermos/common/test_task_planner.py::test_task_process_cannot_depend_upon_daemon [32mPASSED[0m src/test/python/apache/thermos/common/test_task_planner.py::test_task_non_ephemeral_process_cannot_depend_on_ephemeral_process [32mPASSED[0m src/test/python/apache/thermos/common/test_task_planner.py::test_task_failed_predecessor_does_not_make_process_runnable [32mPASSED[0m src/test/python/apache/thermos/common/test_task_planner.py::test_task_daemon_duration [32mPASSED[0m src/test/python/apache/thermos/common/test_task_planner.py::test_task_waits [32mPASSED[0m src/test/python/apache/thermos/common/test_task_planner.py::test_task_fails [32mPASSED[0m src/test/python/apache/thermos/common/test_task_planner.py::test_task_lost [32mPASSED[0m src/test/python/apache/thermos/common/test_task_planner.py::test_task_filters [32mPASSED[0m src/test/python/apache/thermos/common/test_task_planner.py::test_task_max_runs [32mPASSED[0m src/test/python/apache/thermos/common/test_pathspec.py::test_legacy_task_roots [32mPASSED[0m src/test/python/apache/thermos/common/test_pathspec.py::test_legacy_log_dirs [32mPASSED[0m src/test/python/apache/thermos/common/test_pathspec.py::test_exception_on_none_keys [32mPASSED[0m src/test/python/apache/thermos/common/test_planner.py::test_planner_empty [32mPASSED[0m src/test/python/apache/thermos/common/test_planner.py::test_planner_unordered [32mPASSED[0m src/test/python/apache/thermos/common/test_planner.py::test_planner_ordered [32mPASSED[0m src/test/python/apache/thermos/common/test_planner.py::test_planner_mixed [32mPASSED[0m src/test/python/apache/thermos/common/test_planner.py::test_planner_unsatisfiables [32mPASSED[0m ==================== FAILURES ==================== _____________ test_environment_names _____________ [1m def test_environment_names():[0m [1m base_job = Job([0m [1m name='hello_world', role='john_doe', cluster='test-cluster',[0m [1m task=Task(name='main', processes=[],[0m [1m resources=Resources(cpu=0.1, ram=64 * MB, disk=64 * MB)))[0m [1m [0m [1m with pytest.raises(ValueError):[0m [1m> config._validate_environment_name(AuroraConfig(base_job))[0m [1m[31mE AttributeError: 'module' object has no attribute '_validate_environment_name'[0m src/test/python/apache/aurora/client/test_config.py:155: AttributeError generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/aaf4d108c31293299a0839bdc404a91802f80937.xml [1m[31m 1 failed, 795 passed, 6 skipped, 1 warnings in 301.91 seconds [0m FAILURE 15:15:36 05:43 [complete][31m FAILURE[0m I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 14, 2017, 2:55 p.m., Mauricio Garavaglia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62692/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2017, 2:55 p.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora > > > Description > ------- > > Moves the job environment validation to the scheduler, which can be enabled > with the scheduler require_predefined_environments flag. This allows to have > a consistent behavior when using the CLI and the API. In order to preserve > backward compatibility, the validation is kept in the CLI and for the API it > needs to be manually enabled in the scheduler. > > > Diffs > ----- > > docs/features/multitenancy.md 301170daa5ecb92f748994c40bb3f9f1f3871e53 > docs/reference/configuration.md 0231c9265a8134e9b4541e131c3589c96df81274 > docs/reference/scheduler-configuration.md > 4e3f90713c307e3b9e9f84c29343af7f014f0165 > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > 54d7d4ce0e93ca2278bb5f176e633ad72991ee9d > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 60bbe39d1282ccaa1bb91ad595412d55d115e6c5 > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > b7f5e35079431d26065bc95430badb3e6d229a2a > src/main/python/apache/aurora/client/config.py > 70c2c980309e18de576b251087cdfea00ac06b75 > src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java > 9b4f2ad15ab5b61d4cccfad38ba48f17e7853425 > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > 265e87ea9ec0bf3a73a1b5e9d7c40e3d9c79e863 > src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java > 459d6bebcd7d6341dac2aead7e3dd8ce87bc9ed6 > src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java > 3c5ecd698557cafdf8eeacdc472589a379018896 > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java > 2cd19d572d2945e28630b9bce5ba58eb9753630a > > > Diff: https://reviews.apache.org/r/62692/diff/5/ > > > Testing > ------- > > > Thanks, > > Mauricio Garavaglia > >