> On Oct. 12, 2017, 8:08 p.m., Stephan Erb wrote: > > Looks good to me in general. > > > > We'll need to update the docs as well. Please: > > > > * Add a section to the RELEASE-NOTES to indicate that scheduler > > environments are now configurable on the scheduler side > > * Update the docs. In particular > > https://github.com/apache/aurora/blob/master/docs/features/multitenancy.md#job-namespaces > > and > > https://github.com/apache/aurora/blob/master/docs/reference/configuration.md#job-objects > > should be updated that these are just the defaults but could be changed by > > an operator > > > > Thanks!
docs updated > On Oct. 12, 2017, 8:08 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > > Lines 70 (patched) > > <https://reviews.apache.org/r/62692/diff/4/?file=1853684#file1853684line70> > > > > IIRC, the OR operator has the lowest precedence. This would imply we'd > > need to change this regex to `^(prod|devel|test|staging\d*)$` good catch! - Mauricio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review187857 ----------------------------------------------------------- On Oct. 14, 2017, 2:55 p.m., Mauricio Garavaglia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62692/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2017, 2:55 p.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora > > > Description > ------- > > Moves the job environment validation to the scheduler, which can be enabled > with the scheduler require_predefined_environments flag. This allows to have > a consistent behavior when using the CLI and the API. In order to preserve > backward compatibility, the validation is kept in the CLI and for the API it > needs to be manually enabled in the scheduler. > > > Diffs > ----- > > docs/features/multitenancy.md 301170daa5ecb92f748994c40bb3f9f1f3871e53 > docs/reference/configuration.md 0231c9265a8134e9b4541e131c3589c96df81274 > docs/reference/scheduler-configuration.md > 4e3f90713c307e3b9e9f84c29343af7f014f0165 > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > 54d7d4ce0e93ca2278bb5f176e633ad72991ee9d > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 60bbe39d1282ccaa1bb91ad595412d55d115e6c5 > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > b7f5e35079431d26065bc95430badb3e6d229a2a > src/main/python/apache/aurora/client/config.py > 70c2c980309e18de576b251087cdfea00ac06b75 > src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java > 9b4f2ad15ab5b61d4cccfad38ba48f17e7853425 > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > 265e87ea9ec0bf3a73a1b5e9d7c40e3d9c79e863 > src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java > 459d6bebcd7d6341dac2aead7e3dd8ce87bc9ed6 > src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java > 3c5ecd698557cafdf8eeacdc472589a379018896 > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java > 2cd19d572d2945e28630b9bce5ba58eb9753630a > > > Diff: https://reviews.apache.org/r/62692/diff/5/ > > > Testing > ------- > > > Thanks, > > Mauricio Garavaglia > >
