jiajunwang commented on a change in pull request #490: Add latency metric
components for WAGED rebalancer
URL: https://github.com/apache/helix/pull/490#discussion_r329776787
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
##########
@@ -450,12 +499,42 @@ private void
validateInput(ResourceControllerDataProvider clusterData,
if (!currentStateMap.isEmpty()) {
ResourceAssignment newResourceAssignment = new
ResourceAssignment(resourceName);
currentStateMap.entrySet().stream().forEach(currentStateEntry -> {
- newResourceAssignment
- .addReplicaMap(currentStateEntry.getKey(),
currentStateEntry.getValue());
+ newResourceAssignment.addReplicaMap(currentStateEntry.getKey(),
+ currentStateEntry.getValue());
});
currentStateAssignment.put(resourceName, newResourceAssignment);
}
}
return currentStateAssignment;
}
+
+ /**
+ * Creates and registers all metrics in MetricCollector for WagedRebalancer.
+ */
+ private void registerMetrics() throws JMException {
Review comment:
I think this method should be located at the same place where the
_metricCollector is constructed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
