jiajunwang commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r329785737
########## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/metrics/model/LatencyMetric.java ########## @@ -0,0 +1,52 @@ +package org.apache.helix.controller.rebalancer.waged.metrics.model; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import com.codahale.metrics.Histogram; +import org.apache.helix.monitoring.mbeans.dynamicMBeans.HistogramDynamicMetric; + +/** + * Represents a latency metric and defines methods to help with calculation. A latency metric gives + * how long a particular stage in the logic took in milliseconds. + */ +public abstract class LatencyMetric extends HistogramDynamicMetric implements Metric { + protected long _startTime; + protected long _endTime; + protected String _metricName; + + /** + * Instantiates a new Histogram dynamic metric. + * @param metricName the metric name + * @param metricObject the metric object + */ + public LatencyMetric(String metricName, Histogram metricObject) { Review comment: Can we just construct a new Histogram inside the constructor? I think there was some restriction preventing us from doing so. But I don't see any problem if we do it here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
