jiajunwang commented on a change in pull request #490: Add latency metric
components for WAGED rebalancer
URL: https://github.com/apache/helix/pull/490#discussion_r329773765
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
##########
@@ -226,16 +247,25 @@ private void
refreshBaseline(ResourceControllerDataProvider clusterData,
Map<HelixConstants.ChangeType, Set<String>> clusterChanges, Map<String,
Resource> resourceMap,
final CurrentStateOutput currentStateOutput) throws
HelixRebalanceException {
LOG.info("Start calculating the new baseline.");
+
+ // Read the baseline from metadata store
+
_metricCollector.getMetric(WagedRebalancerMetricNames.GlobalStateReadLatencyGauge.name(),
Review comment:
Same here, please push to the most detailed private method if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
