jiajunwang commented on a change in pull request #490: Add latency metric
components for WAGED rebalancer
URL: https://github.com/apache/helix/pull/490#discussion_r330689995
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
##########
@@ -104,7 +109,7 @@ public Object call() {
}
private BestPossibleStateOutput compute(ClusterEvent event, Map<String,
Resource> resourceMap,
- CurrentStateOutput currentStateOutput) {
+ CurrentStateOutput currentStateOutput) throws JMException {
Review comment:
Same here, we don't want any monitor logic to block business. No matter how
broken it could be.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
