jiajunwang commented on a change in pull request #490: Add latency metric
components for WAGED rebalancer
URL: https://github.com/apache/helix/pull/490#discussion_r330686086
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
##########
@@ -134,10 +145,9 @@ public void close() {
*/
public Map<String, IdealState>
computeNewIdealStates(ResourceControllerDataProvider clusterData,
Map<String, Resource> resourceMap, final CurrentStateOutput
currentStateOutput)
- throws HelixRebalanceException {
+ throws HelixRebalanceException, JMException {
Review comment:
Don't throw the monitor exception. Just log the error and ignore it. We
don't want the monitor logic or bug to block business logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
