jiajunwang commented on a change in pull request #490: Add latency metric
components for WAGED rebalancer
URL: https://github.com/apache/helix/pull/490#discussion_r329773415
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
##########
@@ -189,15 +200,25 @@ public void close() {
return itemKeys;
}));
+ // Perform Global Baseline Calculation
+
_metricCollector.getMetric(WagedRebalancerMetricNames.GlobalBaselineCalcLatencyGauge.name(),
Review comment:
1. this is too verbose, let's have a temp var for the metric instance.
2. better to be moved into the refreshBaseline/partialRebalance method. Note
that if no global rebalance is done, your metric will record a garbage latency
number.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
