jiajunwang commented on a change in pull request #851: Add customized view computation and modify Helix generic controller to include new stage URL: https://github.com/apache/helix/pull/851#discussion_r388626886
########## File path: helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java ########## @@ -286,6 +292,27 @@ private void refreshResourceConfig(final HelixDataAccessor accessor, } } + private void refreshCustomizedStateAggregationConfig(final HelixDataAccessor accessor, Review comment: This logic should be resource controller data provider only, I think. It is not required by TF. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org