zhangmeng916 commented on a change in pull request #851: Add customized view computation and modify Helix generic controller to include new stage URL: https://github.com/apache/helix/pull/851#discussion_r389473129
########## File path: helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java ########## @@ -96,13 +99,15 @@ // Special caches private CurrentStateCache _currentStateCache; + private CustomizedStateCache _customizedStateCache; private InstanceMessagesCache _instanceMessagesCache; // Other miscellaneous caches private Map<String, Long> _instanceOfflineTimeMap; private Map<String, Map<String, String>> _idealStateRuleMap; private Map<String, Map<String, Set<String>>> _disabledInstanceForPartitionMap = new HashMap<>(); private Set<String> _disabledInstanceSet = new HashSet<>(); + private Set<String> _aggregationEnabledTypes = new HashSet<>(); Review comment: I added the aggregationEnableType back, as it will break some test. The main reason is that if we put the accessing to ZK inside customized state cache, it will break some assumption in the mock zk Helix accessor about refresh logic, and the calculation for "config" type would be wrong. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
