zhangmeng916 commented on a change in pull request #851: Add customized view 
computation and modify Helix generic controller to include new stage
URL: https://github.com/apache/helix/pull/851#discussion_r390022436
 
 

 ##########
 File path: 
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
 ##########
 @@ -1072,6 +1152,25 @@ protected void 
checkLiveInstancesObservation(List<LiveInstance> liveInstances,
         }
       }
 
+      for (String instance : curInstances.keySet()) {
+        if (lastInstances == null || !lastInstances.containsKey(instance)) {
+          try {
 
 Review comment:
   Please see the updated code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org

Reply via email to