Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 )
Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. ...................................................................... Patch Set 2: (2 comments) > (1 comment) > > Please add a test as Phil suggested. If we decide to add 64-bit > timestamps to the profile, please file a JIRA for it. Alas, I haven't yet found a quick way to add the test. How does one get a query id from a query handle/result (returned by execute_query_async/execute_query)? If I know the query id, that can be passed to read_profile_page from where we can extract the fields of interest. http://gerrit.cloudera.org:8080/#/c/8611/2/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/8611/2/be/src/service/client-request-state.cc@110 PS2, Line 110: summary_profile_->AddInfoString("Start Time", ToStringFromUnixMicros(start_time_us(), : TimePrecision::Nanosecond)); > I'm not sure that TODO is the right thing because then the units are even l That's a good point. http://gerrit.cloudera.org:8080/#/c/8611/2/be/src/service/client-request-state.cc@110 PS2, Line 110: summary_profile_->AddInfoString("Start Time", ToStringFromUnixMicros(start_time_us(), : TimePrecision::Nanosecond)); > Please add a comment as to why we use nano-second here: Added comments explaining why nanosecond precision is used. -- To view, visit http://gerrit.cloudera.org:8080/8611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0 Gerrit-Change-Number: 8611 Gerrit-PatchSet: 2 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Tue, 21 Nov 2017 08:39:03 +0000 Gerrit-HasComments: Yes