Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 )
Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/8611/4/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/8611/4/tests/query_test/test_observability.py@128 PS4, Line 128: while (time.time() - start_time < 10): My suspicion is that it would be safer to have a larger timeout. http://gerrit.cloudera.org:8080/#/c/8611/4/tests/query_test/test_observability.py@129 PS4, Line 129: profile_page = service.read_debug_webpage("query_profile?query_id=%s&raw" % (query_id)) nit: long line http://gerrit.cloudera.org:8080/#/c/8611/4/tests/query_test/test_observability.py@131 PS4, Line 131: print 'Profile page does not seem ready (len=%d)' % (len(profile_page)) May consider throttling this log output to only print it if the debug webpage is not ready after the timeout period. -- To view, visit http://gerrit.cloudera.org:8080/8611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0 Gerrit-Change-Number: 8611 Gerrit-PatchSet: 4 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Tue, 21 Nov 2017 21:57:26 +0000 Gerrit-HasComments: Yes
