Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 )
Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. ...................................................................... Patch Set 4: (5 comments) Uploading a new patch set. Please let me know if this looks ok. http://gerrit.cloudera.org:8080/#/c/8611/4/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/8611/4/tests/query_test/test_observability.py@116 PS4, Line 116: nanosecond precision.""" > I think this needs a bit more explanation as to why nanoseconds precision i Added more explanation. http://gerrit.cloudera.org:8080/#/c/8611/4/tests/query_test/test_observability.py@128 PS4, Line 128: while (time.time() - start_time < 10): > My suspicion is that it would be safer to have a larger timeout. Setting the timeout to 120 seconds. But we should be breaking the loop much much sooner in almost all cases. http://gerrit.cloudera.org:8080/#/c/8611/4/tests/query_test/test_observability.py@129 PS4, Line 129: query_profile > should that be query_profile_encoded? seems like that's the one that would query_profile_encoded gives the raw thrift object. http://gerrit.cloudera.org:8080/#/c/8611/4/tests/query_test/test_observability.py@130 PS4, Line 130: if len(profile_page) < 100: > so i guess the internval/timeout for read_debug_webpage() isn't sufficient Good suggestion. I've changed the loop to lookout for start and end times, and break as soon as end time shows up. http://gerrit.cloudera.org:8080/#/c/8611/4/tests/query_test/test_observability.py@131 PS4, Line 131: print 'Profile page does not seem ready (len=%d)' % (len(profile_page)) > May consider throttling this log output to only print it if the debug webpa Done -- To view, visit http://gerrit.cloudera.org:8080/8611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0 Gerrit-Change-Number: 8611 Gerrit-PatchSet: 4 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Tue, 21 Nov 2017 22:47:59 +0000 Gerrit-HasComments: Yes
