Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8612 )

Change subject: IMPALA-4132: Use -fno-omit-frame-pointer
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8612/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8612/1//COMMIT_MSG@10
PS1, Line 10: As a result we expect more useful stack
            : traces to be produced.
Just curious how well this works, could you paste a couple of thread stacks 
before and after this change using a stripped binary. It'd be a great change 
from a supportability POV if we can get reliable stacks without having to 
attach symbols separately.



-- 
To view, visit http://gerrit.cloudera.org:8080/8612
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7d0d88ba015a847356ed0274fe91017b98cb941
Gerrit-Change-Number: 8612
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Nov 2017 17:33:17 +0000
Gerrit-HasComments: Yes

Reply via email to