Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8629 )
Change subject: IMPALA-5146: Fix inconsitent results at FROM_UNIXTIME() ...................................................................... Patch Set 1: (1 comment) Thanks for your comment http://gerrit.cloudera.org:8080/#/c/8629/1/be/src/exprs/timestamp-functions-ir.cc File be/src/exprs/timestamp-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/8629/1/be/src/exprs/timestamp-functions-ir.cc@84 PS1, Line 84: ToUnixTime > i think it would be clearer to just call tv.HasDateAndTime() directly to sh Done -- To view, visit http://gerrit.cloudera.org:8080/8629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3a5e9a9cb39d32993fa2c7f725be44d8b9ce9f2 Gerrit-Change-Number: 8629 Gerrit-PatchSet: 1 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Comment-Date: Thu, 23 Nov 2017 01:58:55 +0000 Gerrit-HasComments: Yes
