Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8629 )
Change subject: IMPALA-5146: Fix inconsitent results at FROM_UNIXTIME() ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8629/2/be/src/exprs/timestamp-functions-ir.cc File be/src/exprs/timestamp-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/8629/2/be/src/exprs/timestamp-functions-ir.cc@82 PS2, Line 82: & > I'd suggest a non-reference here. I think Henry R. caught a bug in the last Thanks for the information. I guess TimestampValue might have a dangling pointer at a member variable such as posix_time::time_duration or gregorian::date . Would you please share commit id or gerrit link for the bug fix? Regarding unavailability of the reference, I hope we should fix TImestampValue itself to use reference type because some developers who don't know this restriction which makes a corruption unexpectedly. You know there is unexpected cpu cost for memcpy by copying values of the object if we don't use reference. I guess use of shared_ptr might solve this problem. Was it filed on Jira? http://gerrit.cloudera.org:8080/#/c/8629/2/be/src/exprs/timestamp-functions-ir.cc@96 PS2, Line 96: & Is it a problematic code also? -- To view, visit http://gerrit.cloudera.org:8080/8629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3a5e9a9cb39d32993fa2c7f725be44d8b9ce9f2 Gerrit-Change-Number: 8629 Gerrit-PatchSet: 2 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Comment-Date: Mon, 27 Nov 2017 09:32:32 +0000 Gerrit-HasComments: Yes
