Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8629 )
Change subject: IMPALA-5146: Fix inconsitent results at FROM_UNIXTIME() ...................................................................... Patch Set 4: (2 comments) Thanks Dan for the notification. http://gerrit.cloudera.org:8080/#/c/8629/4/testdata/workloads/functional-query/queries/QueryTest/exprs.test File testdata/workloads/functional-query/queries/QueryTest/exprs.test: http://gerrit.cloudera.org:8080/#/c/8629/4/testdata/workloads/functional-query/queries/QueryTest/exprs.test@2518 PS4, Line 2518: 'NULL' I am wondering why the test expects 'NULL' string instead of NULL. As you know, 'NULL' is totally different to NULL. I think it's misleading. Is there any historical reason? I found several cases when return type is string. http://gerrit.cloudera.org:8080/#/c/8629/4/testdata/workloads/functional-query/queries/QueryTest/exprs.test@2553 PS4, Line 2553: 'NULL' : ---- TYPES : STRING Expects 'NULL' literal string -- To view, visit http://gerrit.cloudera.org:8080/8629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3a5e9a9cb39d32993fa2c7f725be44d8b9ce9f2 Gerrit-Change-Number: 8629 Gerrit-PatchSet: 4 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Comment-Date: Wed, 29 Nov 2017 01:42:32 +0000 Gerrit-HasComments: Yes
