Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 )
Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/8270/6/be/src/rpc/rpc-mgr.cc File be/src/rpc/rpc-mgr.cc: http://gerrit.cloudera.org:8080/#/c/8270/6/be/src/rpc/rpc-mgr.cc@75 PS6, Line 75: FLAGS_rpc_authentication = "required"; > Ah I forgot to do this earlier. I now asked the Kudu team about this and th Seems that we should still explicitly set FLAGS_rpc_authentication unless there is a reason why the client and Impala should diverge on the Kerberos setting. http://gerrit.cloudera.org:8080/#/c/8270/6/be/src/rpc/rpc-mgr.cc@128 PS6, Line 128: FLAGS_rpc_authentication = flag_save_rpc_authentication; > I removed this now. But the reason for restoring it was that our tests star I see. If this turns out to be necessary, we can consider doing it in the TearDown() method of the test itself. -- To view, visit http://gerrit.cloudera.org:8080/8270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8cec5cca5fdb4b1d46bab19e86cb1a8a3ad718fd Gerrit-Change-Number: 8270 Gerrit-PatchSet: 6 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Wed, 29 Nov 2017 20:34:23 +0000 Gerrit-HasComments: Yes
