Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 )
Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/8270/6/be/src/rpc/rpc-mgr.cc File be/src/rpc/rpc-mgr.cc: http://gerrit.cloudera.org:8080/#/c/8270/6/be/src/rpc/rpc-mgr.cc@75 PS6, Line 75: KUDU_RETURN_IF_ERROR(bld.Build(&messenger_), "Could not build messenger"); > As discussed offline, this flag also affects the Kudu client so it's best t Done http://gerrit.cloudera.org:8080/#/c/8270/6/be/src/rpc/rpc-mgr.cc@128 PS6, Line 128: nst kudu::rpc::ErrorStatusPB* err = rpc_controller.error > I see. If this turns out to be necessary, we can consider doing it in the T I removed this, so it's no longer necessary. -- To view, visit http://gerrit.cloudera.org:8080/8270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8cec5cca5fdb4b1d46bab19e86cb1a8a3ad718fd Gerrit-Change-Number: 8270 Gerrit-PatchSet: 7 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Fri, 01 Dec 2017 15:59:10 +0000 Gerrit-HasComments: Yes
