Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 )
Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos ...................................................................... Patch Set 8: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/8270/8/be/src/rpc/rpc-mgr.cc File be/src/rpc/rpc-mgr.cc: http://gerrit.cloudera.org:8080/#/c/8270/8/be/src/rpc/rpc-mgr.cc@53 PS8, Line 53: // KuduRPC's flags : DECLARE_string(rpc_authentication); This can be removed now. http://gerrit.cloudera.org:8080/#/c/8270/8/be/src/util/auth-util.cc File be/src/util/auth-util.cc: http://gerrit.cloudera.org:8080/#/c/8270/8/be/src/util/auth-util.cc@93 PS8, Line 93: split(names, names[1], is_any_of("@")); Did you double check if it's okay to use the same vector for both input and output ? -- To view, visit http://gerrit.cloudera.org:8080/8270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8cec5cca5fdb4b1d46bab19e86cb1a8a3ad718fd Gerrit-Change-Number: 8270 Gerrit-PatchSet: 8 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Fri, 01 Dec 2017 19:23:16 +0000 Gerrit-HasComments: Yes
