Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9038 )
Change subject: IMPALA-2642: Fix a potential deadlock in statestore ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9038/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9038/2//COMMIT_MSG@17 PS2, Line 17: Testing: The problem is easily reproduced by lowering the value of : STATESTORE_MAX_SUBSCRIBERS to 3, and then launching a mini cluster : with 3 impalads. With the fix, we can see the following entry in the : statestore log: Is it possible to add a test for this? http://gerrit.cloudera.org:8080/#/c/9038/2/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/9038/2/be/src/statestore/statestore.cc@353 PS2, Line 353: // Assumes that the caller has taken subscribers_lock_ I would add this comment in the header comment in the .h file. -- To view, visit http://gerrit.cloudera.org:8080/9038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d49dede221ce1f50ec299643b5532c61f93f0c6 Gerrit-Change-Number: 9038 Gerrit-PatchSet: 2 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Jan 2018 21:22:38 +0000 Gerrit-HasComments: Yes
