Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9038 )
Change subject: IMPALA-2642: Fix a potential deadlock in statestore ...................................................................... Patch Set 3: (4 comments) Thanks for adding the test. It looks good, just a few more comments. http://gerrit.cloudera.org:8080/#/c/9038/3/tests/custom_cluster/test_custom_statestore.py File tests/custom_cluster/test_custom_statestore.py: http://gerrit.cloudera.org:8080/#/c/9038/3/tests/custom_cluster/test_custom_statestore.py@34 PS3, Line 34: from thrift.transport import TSocket : from thrift.transport import TTransport one line http://gerrit.cloudera.org:8080/#/c/9038/3/tests/custom_cluster/test_custom_statestore.py@39 PS3, Line 39: from StatestoreService.StatestoreSubscriber import TUpdateStateResponse : from StatestoreService.StatestoreSubscriber import TTopicRegistration Needed? http://gerrit.cloudera.org:8080/#/c/9038/3/tests/custom_cluster/test_custom_statestore.py@42 PS3, Line 42: from Status.ttypes import TStatus Needed? http://gerrit.cloudera.org:8080/#/c/9038/3/tests/custom_cluster/test_custom_statestore.py@52 PS3, Line 52: handle = socket.socket(socket.AF_INET, socket.SOCK_STREAM) : handle.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1) : handle.bind(('localhost', 0)) : _, port = handle.getsockname() Does this mean that every "statestore subscriber" uses the same port? Looks like this would run just once at class initialization? -- To view, visit http://gerrit.cloudera.org:8080/9038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d49dede221ce1f50ec299643b5532c61f93f0c6 Gerrit-Change-Number: 9038 Gerrit-PatchSet: 3 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Mon, 29 Jan 2018 19:58:48 +0000 Gerrit-HasComments: Yes
