Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9038 )
Change subject: IMPALA-2642: Fix a potential deadlock in statestore ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Thanks for fixing this. LGTM http://gerrit.cloudera.org:8080/#/c/9038/3/tests/custom_cluster/test_custom_statestore.py File tests/custom_cluster/test_custom_statestore.py: http://gerrit.cloudera.org:8080/#/c/9038/3/tests/custom_cluster/test_custom_statestore.py@52 PS3, Line 52: _, port = handle.getsockname() : : @classmethod : def get_workload(self): > That's correct. All the subscribers we create below will connect from the s That's fine, I was just wondering if it will test what we require, but it seems like it does. Could you just add a comment stating that even though all subscribers share the same port, they all have different subsciber IDs, so it's clear to readers of this file? -- To view, visit http://gerrit.cloudera.org:8080/9038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d49dede221ce1f50ec299643b5532c61f93f0c6 Gerrit-Change-Number: 9038 Gerrit-PatchSet: 4 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Mon, 29 Jan 2018 21:10:56 +0000 Gerrit-HasComments: Yes
