Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 )
Change subject: IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/9147/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9147/2//COMMIT_MSG@12 PS2, Line 12: j > nit: Jira Done http://gerrit.cloudera.org:8080/#/c/9147/2//COMMIT_MSG@16 PS2, Line 16: Testing > nit: remove the indent here Done http://gerrit.cloudera.org:8080/#/c/9147/2/fe/src/main/java/org/apache/impala/catalog/KuduTable.java File fe/src/main/java/org/apache/impala/catalog/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/9147/2/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@396 PS2, Line 396: return true; > nit: if and return could go on a single line now Done -- To view, visit http://gerrit.cloudera.org:8080/9147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2 Gerrit-Change-Number: 9147 Gerrit-PatchSet: 3 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Comment-Date: Mon, 29 Jan 2018 23:10:03 +0000 Gerrit-HasComments: Yes