Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 )
Change subject: IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/9147/5/fe/src/main/java/org/apache/impala/catalog/KuduTable.java File fe/src/main/java/org/apache/impala/catalog/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/9147/5/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@391 PS5, Line 391: public boolean isPrimaryKeyColumn(String name) { > Were you able to reproduce the reported issue? Yes the issue is reproducible without the fix, when the new CTAS test case is run it fails. I checked the code to see how primaryKeyColumnNames_ is being populated it appears that there is no explicit conversion to convert it to lower case, it seems to be populated by parser. So it is directly taking the case specified by the user and comparing it against lower case (Column.getName()) CreateTableAsSelectStmt.analyze (line# 193) +--KuduTable.createCtasTarget (line #327) -->createStmt_.getTblPrimaryKeyColumnNames() -->TableDef.primaryKeyColNames_ { This in turn seems to be populated by the parser } http://gerrit.cloudera.org:8080/#/c/9147/5/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test: http://gerrit.cloudera.org:8080/#/c/9147/5/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@292 PS5, Line 292: create table partitioned_kudu_tbl > Bug was hit in the FE so an Analyzer test in AnalyzeDDL#TestCreateTableAsSe Moved over the test case to AnalyzeDDLTest.java -- To view, visit http://gerrit.cloudera.org:8080/9147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2 Gerrit-Change-Number: 9147 Gerrit-PatchSet: 5 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Comment-Date: Tue, 30 Jan 2018 07:05:17 +0000 Gerrit-HasComments: Yes
