Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 )
Change subject: IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/9147/5/fe/src/main/java/org/apache/impala/catalog/KuduTable.java File fe/src/main/java/org/apache/impala/catalog/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/9147/5/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@391 PS5, Line 391: public boolean isPrimaryKeyColumn(String name) { Were you able to reproduce the reported issue? I believe that Thomas' recent cleanup should have already fixed this issue (see https://gerrit.cloudera.org/#/c/6902/) * Take a look at how primaryKeyColumnNames_ is populated. Should always be lower case. * Take a look at the callers of isPrimaryKeyColumn(). For example, InsertStmt#prepareExpressions() calls this function passing in a Column.getName() which is always lower case (enforced in the Column constructor) If we are still hitting this issue, there might be a deeper issue that we need to investigate. http://gerrit.cloudera.org:8080/#/c/9147/5/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test: http://gerrit.cloudera.org:8080/#/c/9147/5/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@292 PS5, Line 292: create table partitioned_kudu_tbl Bug was hit in the FE so an Analyzer test in AnalyzeDDL#TestCreateTableAsSelect is more appropriate. -- To view, visit http://gerrit.cloudera.org:8080/9147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2 Gerrit-Change-Number: 9147 Gerrit-PatchSet: 5 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Comment-Date: Tue, 30 Jan 2018 01:02:41 +0000 Gerrit-HasComments: Yes
