Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9153 )
Change subject: IMPALA-5293: Turn insert clustering on by default ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9153/3/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java: http://gerrit.cloudera.org:8080/#/c/9153/3/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java@831 PS3, Line 831: analyzer.addWarning("Clustering is enabled by default, use 'noclustered' to " + > Adding the hint should not have any effect since we don't ensure to add a c I'd lean towards re-adding it for Kudu tables, although it is not that useful - ignoring the hint seems a bit weird. I do feel like we shouldn't warn here since it could be annoying and there's no way to disable the warning. I understand that confused users might add it without understanding it's currently a no-op, but that seems fairly harmless. It's a bit of a problem if the user actually wants to retain the hint - either it they might be carried over from a query written when it wasn't a default, or maybe the user is intending to force a particular plan to prevent future plan changes (or ensure consistent behaviour on different versions of Impala). -- To view, visit http://gerrit.cloudera.org:8080/9153 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbf2368cf4415e6ecfa65058daf6ff87ef62f9d9 Gerrit-Change-Number: 9153 Gerrit-PatchSet: 3 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 30 Jan 2018 23:18:33 +0000 Gerrit-HasComments: Yes
