Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9153 )

Change subject: IMPALA-5293: Turn insert clustering on by default
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9153/5/testdata/workloads/functional-planner/queries/PlannerTest/insert.test
File testdata/workloads/functional-planner/queries/PlannerTest/insert.test:

http://gerrit.cloudera.org:8080/#/c/9153/5/testdata/workloads/functional-planner/queries/PlannerTest/insert.test@813
PS5, Line 813: # IMPALA-6280: clustered (default) with outer join, inline view, 
and TupleisNullPredicate
> I changed it to use alltypessmall like the other tests in this file.
I think we should remove this planner test because it's somewhat misleading. 
The bug in IMPALA-6280 only shows up at runtime, so this planner test arguably 
does not cover IMPALA-6280.



--
To view, visit http://gerrit.cloudera.org:8080/9153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbf2368cf4415e6ecfa65058daf6ff87ef62f9d9
Gerrit-Change-Number: 9153
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Feb 2018 00:33:38 +0000
Gerrit-HasComments: Yes

Reply via email to